Closed ghost closed 1 year ago
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.
Hi @christinavoudouris
I ran a regex query on all these files to remove whitespace at the end of the lines, and clearly copied in part of my regexp by accident into the page. I have removed that but reverted the other indentation changes. They might work, but the existing format also works, and matches the documents that are already published https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Displaying_data/Book_list_page
Thanks so much for taking the time to add a fix - much appreciated.
@christinavoudouris I tried to merge this, but the commit you made was not signed, and this repo won't allow me to accept it. Very annoying.
Because this is an example to people I consider it a bit urgent, so I have instead reproduced your change - #178 Thanks so much for taking the time to post.
@schalkneethling Do you have rights to remove the requirement for signed contributions. I see that as a barrier to contribution - is there some non obvious value to requiring it?
I tried to merge this, but the commit you made was not signed, and this repo won't allow me to accept it.
The restriction only allowing signed commits is now lifted in the branch protection rules for this repo 👍🏻
THanks @bsmth - much appreciated!!!
Description
Hi! Just found a typo that was messing up the page render. I also fixed formatting to match similar files.