search

mdn / express-locallibrary-tutorial

Local Library website written in NodeJS/Express; example for the MDN server-side development NodeJS module: https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs.
Creative Commons Zero v1.0 Universal
1.23k stars 695 forks source link

Update express-validator package to v7.0.1 and replace deprecated code with recommended code #189

Closed TruePadawan closed 1 year ago

TruePadawan commented 1 year ago

Description

I updated the express-validator package to v7.0.1 and also updated deprecated code from the package to the recommended code

Motivation

Additional details

I've tested that the app works fine after the changes

Related issues and pull requests

github-actions[bot] commented 1 year ago

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

schalkneethling commented 1 year ago

Hey, @TruePadawan 👋 Thank you for your pull request. We manage dependency updates using Dependabot. You can see a pull request here proposing the same package update. If you can revert the change to package.json and package-lock.json, we can continue the review of the pull request.

TruePadawan commented 1 year ago

@schalkneethling I'm new to contributing to repos so not sure exactly the proper procedures but I think I've just done that, I reverted the commit where I updated the package

schalkneethling commented 1 year ago

@schalkneethling I'm new to contributing to repos so not sure exactly the proper procedures but I think I've just done that, I reverted the commit where I updated the package

Great stuff! That worked perfectly.

TruePadawan commented 1 year ago

What next?

github-actions[bot] commented 1 year ago

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

hamishwillee commented 1 year ago

Thanks @TruePadawan - next step is to update the docs PR https://github.com/mdn/content/pull/26798 with the new changes you made.

@schalkneethling FWIW Normally I don't merge dependabot stuff at all, until I've had a chance to run the code myself. I then merge docs and validation projects at the same time to ensure that everything is in sync.

TruePadawan commented 1 year ago

@hamishwillee What new changes? The PR already has the relevant commits, I'm not sure what you mean.

hamishwillee commented 1 year ago

Perhaps I'm blind, but here I see changes in several files, but in the content PR I only see the author changes (not the bookinstance changes). This shows a check on the "old" check across the express docs.

image

TruePadawan commented 1 year ago

Ah alright, I think I've done it now, probably.

hamishwillee commented 1 year ago

Yes, great job. Thanks very much.