search

mdn / express-locallibrary-tutorial

Local Library website written in NodeJS/Express; example for the MDN server-side development NodeJS module: https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs.
Creative Commons Zero v1.0 Universal
1.23k stars 697 forks source link

Update syntax in bookController to match lesson #245

Closed columk1 closed 9 months ago

columk1 commented 9 months ago

Description

Replaced syntax in the bookController file to to remove inconsistency and to match the syntax used in the tutorial.

Motivation

There were three different implementations of the same logic in the tutorial and project files. It was confusing for readers, since elsewhere in the tutorial the syntax is consistent when code is repeated.

Additional details

Related issues and pull requests

Relates to Issue #30443 mdn/content/issues/30443 Relates to PR #30476 mdn/content/pull/30476

github-actions[bot] commented 9 months ago

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

hamishwillee commented 9 months ago

Looks good. I plan to test this on Monday or Tuesday.

hamishwillee commented 9 months ago

Thanks. Looks good by inspection and also by testing.

github-actions[bot] commented 9 months ago

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.