search

mdn / express-locallibrary-tutorial

Local Library website written in NodeJS/Express; example for the MDN server-side development NodeJS module: https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs.
Creative Commons Zero v1.0 Universal
1.23k stars 696 forks source link

Fixed numerous bugs in the pug templates that resulted in invalid htm… #253

Closed nitramrelpmur closed 9 months ago

nitramrelpmur commented 9 months ago

Description

I fixed numerous bugs in the pug templates (especially in the html forms) that resulted in invalid html markup. I also added missing spaces (e.g. in the detail pages).

Motivation

I wanted to make sure that all pug templates in the tutorial generate only valid html markup.

Additional details

I checked the rendered html ouput with the Nu Html Checker until there were no more errors.

Related issues and pull requests

The errors in the pug templates must also be fixed in the Express Tutorial: The Local Library website. What would be the best way to reflect the changes made in this pull request to the various code examples in the tutorial?

github-actions[bot] commented 9 months ago

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

hamishwillee commented 9 months ago

@nitramrelpmur Looks good - in particular the fixes to remove true off required='true'

Did you test all the affected UI as well? I.e. that it still all works?

Assuming you did, before this was merged we'd need to update the doc. Can you create a PR to do that too? We'd merge them at the same time.

nitramrelpmur commented 9 months ago

@nitramrelpmur Looks good - in particular the fixes to remove true off required='true'

Did you test all the affected UI as well? I.e. that it still all works?

Assuming you did, before this was merged we'd need to update the doc. Can you create a PR to do that too? We'd merge them at the same time.

I just checked all CRUD operations on the entities (genre, author, book, bookinstance) again and validated the generated html output. I found some minor bugs in the pug templates and corrected them. The pushed the new files in my github repository. They should now be part of this pull request.

I will prepare a pull request for the pug templates in the Express Tutorial: The Local Library website.

github-actions[bot] commented 9 months ago

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.