mdn / interactive-examples

Home of the MDN live code editor interactive examples
Creative Commons Zero v1.0 Universal
721 stars 507 forks source link

Improve contrast of interactive example #2054

Open schalkneethling opened 2 years ago

schalkneethling commented 2 years ago

There are probably other situations where too little contrast makes things hard to see. Compare these white letters on bright yellow background atop this page,

https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap

I'll stop reporting these, anyone could find them easily.

Originally posted by @iDave2 in https://github.com/mdn/yari/issues/5387#issuecomment-1055782535

vedant-z commented 1 year ago

![Uploading r4{bfc025b} (290f7d3c-25a8-48b2-b308-0d7245079b1a id=0x7f0a0400 tag=BaseCommentFragment) …]()

@schalkneethling Are you referring to this part. If so I need to change the BG color for better visibility right?

bsmth commented 1 year ago

Has this already been fixed in the following PR?

NiedziolkaMichal commented 1 year ago

Unfortunately there are still plenty of examples with too low contrast.

vedant-z commented 1 year ago

@NiedziolkaMichal Can you point out me some so that I can get started contributing to this repository

NiedziolkaMichal commented 1 year ago

Those are all CSS examples that don't meet proper contrast guidelines in dark theme according to the firefox accessibility tool:

wbamberg commented 1 year ago

This has again been reported at https://github.com/mdn/interactive-examples/issues/2368. It's sad that such a bad usability issue has been open for so long :(

See also https://github.com/mdn/bob/issues/859.