search

mdn / interactive-examples

Home of the MDN live code editor interactive examples
Creative Commons Zero v1.0 Universal
726 stars 506 forks source link

Fix expected output in example for Logical OR assignment (||=) - expressions-logical-or-assignment.js #2796

Closed artemshar closed 1 month ago

artemshar commented 1 month ago

Missing dot in expected output

Description

So as not to frustrate the reader, this operator is not a variation of the trim method. When I first read about this method and this example confused me - “why did the dot disappear?”, but RUN put everything in its place.

Motivation

Perhaps these seconds of frustration will save thousands of developer hours. ;)

Additional details

Perhaps this will be my most significant contribution to open source in my entire life! (one dot in commit)

Related issues and pull requests

☺️

github-actions[bot] commented 1 month ago

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

github-actions[bot] commented 1 month ago

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.