mdn / js-examples

Code examples that accompany the MDN JavaScript/ECMAScript documentation
https://developer.mozilla.org/en-US/docs/Web/JavaScript
Creative Commons Zero v1.0 Universal
1.12k stars 699 forks source link

Rename modules top level directory #17

Closed wbamberg closed 2 years ago

wbamberg commented 2 years ago

This is part of a fix for https://github.com/mdn/content/issues/14677. It would need corresponding updates in (only, AFAICT) https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules.

@Rumyra , I'm not sure if we want to do this. But if we don't, we should close https://github.com/mdn/content/issues/14677 as WONTFIX.

(I think we probably should, but don't feel very strongly either way.)

Rumyra commented 2 years ago

Yeh - I'm happy with module-examples as it's more explicit - but I also think we should have a content update at least in the works before merging 👍

wbamberg commented 2 years ago

Yeh - I'm happy with module-examples as it's more explicit - but I also think we should have a content update at least in the works before merging 👍

I just filed https://github.com/mdn/content/pull/15934 for the other half of this.

mohsinulhaq commented 2 years ago

https://github.com/mdn/js-examples/blob/master/module-examples/README.md Hi, it seems that we missed updating the GitHub Pages link here. :)

wbamberg commented 2 years ago

https://github.com/mdn/js-examples/blob/master/module-examples/README.md Hi, it seems that we missed updating the GitHub Pages link here. :)

Ooops, thank you for letting me know. Filed https://github.com/mdn/js-examples/pull/19. Why do we have 2 READMEs here??

mohsinulhaq commented 2 years ago

I think this readme is supposed to be specifically regarding JS modules, and MDN directly links to this folder on GitHub: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules#introducing_an_example

wbamberg commented 2 years ago

Fair enough. It should be fixed now anyway :).

mohsinulhaq commented 2 years ago

Thanks!