mdn / kuma

The project that powers MDN.
https://developer.mozilla.org
Mozilla Public License 2.0
1.93k stars 679 forks source link

Should we use the auth modal on mobile? #6274

Closed schalkneethling closed 4 years ago

schalkneethling commented 4 years ago

@peterbe brought up a point for discussion here https://github.com/mdn/kuma/pull/6094#pullrequestreview-315193086 around using the auth modal on mobile phones.

My initial thinking was that the benefit of using a modal is largely lost on mobile phones and perhaps, the user experience might be better if we simply send these users on to the dedicated sign-in/up page.

Firstly, I might have been mistaken but also, we do now push down some HTML, CSS and, JS to mobile phone users knowing we will not use it, which is not great at all. This is not easy to solve but, perhaps it does make sense to use the modal on mobile phones as well?

Thoughts? @malqinneh @Gregoor @peterbe

peterbe commented 4 years ago

It should also be noted that we’re sending down JS, HTML, and CSS that even for desktop browsers is not used 99% of the time because signing in is a rare thing to do now that session cookies last a long time.

If we had better tools we could use code splitting to avoid that waste.

On Mon, Dec 23, 2019 at 5:57 AM Schalk Neethling notifications@github.com wrote:

@peterbe https://github.com/peterbe brought up a point for discussion here #6094 (review) https://github.com/mdn/kuma/pull/6094#pullrequestreview-315193086 around using the auth modal on mobile phones.

My initial thinking was that the benefit of using a modal is largely lost on mobile phones and perhaps, the user experience might be better if we simply send these users on to the dedicated sign-in/up page.

Firstly, I might have been mistaken but also, we do now push down some HTML, CSS and, JS to mobile phone users knowing we will not use it, which is not great at all. This is not easy to solve but, perhaps it does make sense to use the modal on mobile phones as well?

Thoughts? @malqinneh https://github.com/malqinneh @Gregoor https://github.com/Gregoor @peterbe https://github.com/peterbe

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mdn/kuma/issues/6274?email_source=notifications&email_token=AAAGQ45JQLWEGW4BB2BWIR3Q2CKRFA5CNFSM4J6SZNC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICJW3FA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGQ45RFR3XI72EZ6VSPYTQ2CKRFANCNFSM4J6SZNCQ .

-- Peter Bengtsson Mozilla MDN Web Docs https://www.peterbe.com

peterbe commented 4 years ago

Let's start with what's ideal?

I quickly browsed a couple of sites to see what they do:

tobinmori commented 4 years ago

Conclusion: