search

mdn / kuma

The project that powers MDN.
https://developer.mozilla.org
Mozilla Public License 2.0
1.93k stars 679 forks source link

Drop 'timezone' from whoami #6750

Closed peterbe closed 4 years ago

peterbe commented 4 years ago

Summary In api/v1/whoami we're including a timezone value.

No code appears to use it for anything. It's mention in user-provider.jsx but only to build up the userData context but nothing beyond that that actually uses it.

Audience Developers

Rationale It's wasting space.

Workaround Our "v1" API isn't a public API because it's based on browser cookies. So we don't have to worry about breaking any third-party apps that depend on this. Not really a workaround.

Proposal Delete it and clean up around it.

Additional context Let's block this on https://github.com/mdn/kuma/issues/6742

peterbe commented 4 years ago

Here's how I can be confident we don't use it for anything:

▶ rgj timezone
../.git/modules/locale/commondir: No such file or directory (os error 2)
../.git/modules/kumascript/commondir: No such file or directory (os error 2)
kuma/javascript/src/user-provider.test.js
73:                        timezone: null,

kuma/javascript/src/user-provider.jsx
14:    timezone: ?string,
31:    timezone: null,
67:                    timezone: data.timezone,

kuma/static/js/libs/jquery-ui-1.10.3.custom/development-bundle/external/globalize.js
1213:           // adjust timezone to utc before applying local offset.