search

mdn / kuma

The project that powers MDN.
https://developer.mozilla.org
Mozilla Public License 2.0
1.93k stars 679 forks source link

unbreak black and Dependabot upgrades #7930

Closed peterbe closed 3 years ago

peterbe commented 3 years ago

At some point, pyproject.toml and poetry.lock got a new version of black. E.g. https://github.com/mdn/kuma/commit/c705739a2596b0d8af7e47ad35a3c79f865bb4d6 What happened was that .github/workflows/python-lints.yml never ran. Now what happens is that the version of black you get inside the docker container doesn't match the version of black used in python-lints.yml. Worse, because it wouldn't even have noticed because a change to pyproject.toml our .py files no longer match that version that you get inside the docker container. So, when you run black inside bash on your docker container, it says some files aren't formatted even though nobody's touched them for ages. This PR solves both problems.

codecov-commenter commented 3 years ago

Codecov Report

Merging #7930 (6f7ce15) into master (ebe8fb8) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 6f7ce15 differs from pull request most recent head 6bd1c68. Consider uploading reports for the commit 6bd1c68 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7930   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files         131      131           
  Lines        5498     5498           
  Branches      463      463           
=======================================
  Hits         4593     4593           
  Misses        800      800           
  Partials      105      105
Impacted Files Coverage Δ
kuma/users/tests/test_adapters.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebe8fb8...6bd1c68. Read the comment docs.