search

mdn / kuma

The project that powers MDN.
https://developer.mozilla.org
Mozilla Public License 2.0
1.93k stars 679 forks source link

periodically refresh documents #7967

Closed peterbe closed 2 years ago

peterbe commented 3 years ago

Fixes #7965

~I'm making it a draft for now because I think there's a mismatch between calling it document_url and documenturl and it would be nice to tidy that up.~ Also, it would be great to have a think about the use case of a 30x redirect and how that should effect.

codecov-commenter commented 3 years ago

Codecov Report

Merging #7967 (9d3445f) into master (f6068e3) will decrease coverage by 1.74%. The diff coverage is 95.40%.

:exclamation: Current head 9d3445f differs from pull request most recent head f6d0b03. Consider uploading reports for the commit f6d0b03 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7967      +/-   ##
==========================================
- Coverage   90.59%   88.85%   -1.75%     
==========================================
  Files          67       63       -4     
  Lines        2317     2063     -254     
  Branches      159      145      -14     
==========================================
- Hits         2099     1833     -266     
- Misses        192      201       +9     
- Partials       26       29       +3
Impacted Files Coverage Δ
kuma/documenturls/models.py 89.85% <85.71%> (+9.42%) :arrow_up:
kuma/api/v1/plus/bookmarks.py 100.00% <100.00%> (+1.96%) :arrow_up:
kuma/api/v1/tests/test_bookmarks.py 100.00% <100.00%> (ø)
kuma/documenturls/apps.py 100.00% <100.00%> (ø)
kuma/documenturls/tasks.py 100.00% <100.00%> (ø)
kuma/documenturls/tests/test_tasks.py 100.00% <100.00%> (ø)
kuma/settings/common.py 95.20% <100.00%> (-0.31%) :arrow_down:
kuma/settings/pytest.py 100.00% <100.00%> (ø)
kuma/api/v1/views.py 65.30% <0.00%> (-34.70%) :arrow_down:
kuma/conftest.py 83.33% <0.00%> (-2.39%) :arrow_down:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6068e3...f6d0b03. Read the comment docs.

peterbe commented 3 years ago

The only possible bug about this is that a document might become a redirect to a new URL that isn't a Yari document. And if an existing document becomes a redirect to another document, we should build some sort of "merge functionality". But it might make sense to stall on that functionality. We don't desperately need it yet and if it starts to cause problems, it'll become a LOT easier to debug and test once it's a real deal.