search

mdn / learning-area

GitHub repo for the MDN Learning Area.
https://developer.mozilla.org/en-US/Learn
Creative Commons Zero v1.0 Universal
7.01k stars 27k forks source link

Text updates on variable change #738

Closed bookofbash closed 4 months ago

bookofbash commented 5 months ago

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/JavaScript/First_steps/Math What specific section or headline is this issue about?

Active learning: sizing a canvas box What information was incorrect, unhelpful, or incomplete?

When changing values of X and Y in the code, I was expecting the string below the canvas to update to the new X and Y values. But they always show: "The rectangle is 50px wide and 50px high." What did you expect to see?

I was expecting for it to update when the values were changed in each exercise Do you have any supporting links, references, or citations?

No response Do you have anything more you want to share?

No response MDN metadata Page report details

Folder: en-us/learn/javascript/first_steps/math
MDN URL: https://developer.mozilla.org/en-US/docs/Learn/JavaScript/First_steps/Math
GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/learn/javascript/first_steps/math/index.md
Last commit: https://github.com/mdn/content/commit/151cdeeba58ffc07f8673af4e303cb1fcbba1bff
Document last modified: 2024-04-29T15:59:22.000Z

Pull request to answer: #33540 The text now changes with user input.

bsmth commented 4 months ago

Thanks a lot for the suggestion, but I'm going to close this one in favor of https://github.com/mdn/learning-area/pull/739. We can access x and y values without parsing the text like lines.find..., does that make sense?

Thanks! 🙌🏻