search

mdn / pab

MDN Web Docs Product Advisory Board
26 stars 17 forks source link

Determine if we can automate PR assignments through a GitHub hook #36

Closed alispivak closed 5 years ago

alispivak commented 6 years ago

Look into if it would be possible to could check which browser data a PR changes with a GitHub hook, then add tags for that browser and assign reviewers as appropriate.

chrisdavidmills commented 5 years ago

Dom sent a PR that would do this; Florian to review.

This also relies on the governance piece.

dontcallmedom commented 5 years ago

The tool is at https://github.com/dontcallmedom/bcd-review-bot/

alispivak commented 5 years ago

@dontcallmedom @Elchi3 Has this PR been reviewed and accepted? Can we close this issue?

Elchi3 commented 5 years ago

Tracked here now: https://github.com/mdn/browser-compat-data/issues/3127

tl;dr We're not interested in this at this stage, given there are no dedicated people from browser vendors who are willing look after their data in day-to-day pull request reviews (Google and Mozilla being the exception). We can re-consider if more reviewers (preferably from all vendors) are involved and there is a need to assign reviews orderly.