mdn / sprints

Archived: MDN Web Docs issues are tracked in the content repository.
https://github.com/mdn/content
Creative Commons Zero v1.0 Universal
149 stars 142 forks source link

U - [HTTP] Docs requirements for SameSite=Lax by default #2152

Closed chrisdavidmills closed 3 years ago

chrisdavidmills commented 5 years ago

User story

As a web developer, I want to reads docs about the new default SameSite setting, so I can find out how this affects my work.

This contributes to MDN's completeness, and the KR "Increase traffic 5% y/y". MDN users need this information to be able to do their jobs effectively going forward.

Background

Same site cookies were shipped a few versions ago. Browser are now agreeing on a proposed change to treat all new cookies as SameSite=lax by default

This is interesting for 2 reasons:

  1. We need to do this to avoid compat issues if other browsers all do it
  2. It is an opportunity to work with other vendors to eliminate entire class of security vulnerabilities (CSFR)

We are trying to line up changes to coincide with other browser vendors, and this includes documentation. Chrome are aiming for about Chrome 78, available behind pref since 76. We are not yet 100% sure what Firefox version it will be enabled in, but it'll probably be Fx 71, or maybe even 70.

Docs updates needed on

New page needed

We may also do with a hacks post to explain the story (how we fixed CSRF forever! google drove it, we thought of it) and what difference this wil make for web devs. This would also coincide with a more technical write up on the Moz sec blog. If these happen, the engineers will write them and we can help edit them.

Mark Goodwin was the engineering contact for this, now it's being implemented by Andrea Marchesini (baku). Ask him for help if needed.

Acceptance criteria

    • [ ] MDN docs written as described above.
    • [ ] hacks and sec blog content reviewed/edited (not sure if this is still needed, will ask)

Enable sameSite=lax by default tracks the release of these changes in final release Fx. Bear in mind that we want to get this done by Fx 76 beta, so we will need to delay communicating that this is enabled in release till a later sprint).

chrisdavidmills commented 4 years ago

I'm clearing the milestone and attachment to Fx71 for now; I was told this would be a big thing to do probably around Fx71, but then heard nothing else about it.

chrisdavidmills commented 4 years ago

More information from chatting to Mike Conca:

Elchi3 commented 4 years ago

I've started a page here in case folks need a URL for the console message now https://wiki.developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite

Will add some more examples and describe the planned change some more.

Also this hasn't landed in Firefox yet, so I haven't updated the BCD for it yet.

Elchi3 commented 4 years ago

So, I think this is done for the moment. mconca seems to be happy with the page (see https://bugzilla.mozilla.org/show_bug.cgi?id=1620334#c4) and we will need to continue this work when it actually lands (probably next sprint with Firefox 76).

Elchi3 commented 4 years ago

Given https://blog.chromium.org/2020/04/temporarily-rolling-back-samesite.html, I think this might not be shipped in Firefox either. So, maybe this should be parked instead of scheduled for the next sprint.

chrisdavidmills commented 4 years ago

@Elchi3 thanks for the heads up.

chrisdavidmills commented 4 years ago

I'll put it in 76 for now, and we can remove it when the official line comes in.

chrisdavidmills commented 4 years ago

Confirmation that this is being pushed out to a future version. We'll park it for now.

hamishwillee commented 3 years ago

Review Status - good but a few minor errors and some layout stuff.

Actions:

hamishwillee commented 3 years ago

@chrisdavidmills I have updated this as above. Specifically this now updates the three main docs that mention SameSite to reflect the new behaviour, and point people to the BCD at end of pages to check specific versions. Details above.

The impact of this change is that the docs will not go out of date with new releases. So when FF accepts the bug the BCD and release note will update, but the docs will be correct.

I think this can probably be closed with a new doc opened when this feature is actually in the live version.

chrisdavidmills commented 3 years ago

@hamishwillee this is looking great, thanks! Yup, I'll close this. The bug referenced above already has dev-doc-needed set, so we'll pick it up again when the bug is resolved.