mdn / sprints

Archived: MDN Web Docs issues are tracked in the content repository.
https://github.com/mdn/content
Creative Commons Zero v1.0 Universal
150 stars 142 forks source link

Organizing your CSS: Missing CSS Class in Non-OOCSS Example Code #2627

Closed marklchaves closed 4 years ago

marklchaves commented 4 years ago

Request type

Details

Hi,

Issue

In the Organizing your CSS article, the non-OOCSS example code seems to be missing a class.

.list-item img { font-size: .8rem; }

Fix

Add the code snippet above to the example at the spot highlighted in the attached screen grab.

mdn-oocss-example-missing-class-2jan2020

chrisdavidmills commented 4 years ago

I think what's there is correct already. The previous text says

The differences between these two components is that the list-item has a bottom border, and images in comments have a border whereas list-item images do not.

So .list-item img specifically does not have a rule setting a border on it (which I think is what you meant, rather than a font-size?)

marklchaves commented 4 years ago

Yikes. Thanks for the quick reply, @chrisdavidmills. My mistake. Apologies for the trouble. Keep up the great work.

mark

chrisdavidmills commented 4 years ago

Yikes. Thanks for the quick reply, @chrisdavidmills. My mistake. Apologies for the trouble. Keep up the great work.

No worries; if you are unsure, then it's always good to check!