mdn / sprints

Archived: MDN Web Docs issues are tracked in the content repository.
https://github.com/mdn/content
Creative Commons Zero v1.0 Universal
151 stars 144 forks source link

Incorrect URL for HTML Drag and Drop API Events #3984

Closed uafrontender closed 3 years ago

uafrontender commented 3 years ago

Request type

Details

Links of drag and drop events in sidebar on https://developer.mozilla.org/en-US/docs/Web/API/HTML_Drag_and_Drop_API redirect to "Page not found" (ie: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/drop_event) Actual content is on https://developer.mozilla.org/en-US/docs/Web/API/Document/drop_event

Selection_004

chrisdavidmills commented 3 years ago

These links are generated from the data inside our GroupData.json — see https://github.com/mdn/yari/blob/master/kumascript/macros/GroupData.json#L782

Whoever fixes this would need to replace HTMLElement with Document in each case.

@mkarkachov , do you fancy having a go at fixing this?

uafrontender commented 3 years ago

These links are generated from the data inside our GroupData.json — see https://github.com/mdn/yari/blob/master/kumascript/macros/GroupData.json#L782

Whoever fixes this would need to replace HTMLElement with Document in each case.

@mkarkachov , do you fancy having a go at fixing this?

gladly

chrisdavidmills commented 3 years ago

These links are generated from the data inside our GroupData.json — see https://github.com/mdn/yari/blob/master/kumascript/macros/GroupData.json#L782 Whoever fixes this would need to replace HTMLElement with Document in each case. @mkarkachov , do you fancy having a go at fixing this?

gladly

great, thanks!

uafrontender commented 3 years ago

@chrisdavidmills Created pull request https://github.com/mdn/yari/pull/2451

chrisdavidmills commented 3 years ago

Cool, PR reviewed and merged, so we should see the update in 24 hours or so.

chrisdavidmills commented 3 years ago

Congrats on your first MDN contribution, and thanks!