search

mdn / sprints

Archived: MDN Web Docs issues are tracked in the content repository.
https://github.com/mdn/content
Creative Commons Zero v1.0 Universal
149 stars 142 forks source link

Refactor mouse events #955

Closed Elchi3 closed 5 years ago

Elchi3 commented 5 years ago

This is a work item for #685.

Pages:

macOS specific

The target here is Element mostly. Some non-standard ones, we will need to see how they fit it.

Acceptance criteria

irenesmith commented 5 years ago

Estimate is based on 5 or 6 pages a day

irenesmith commented 5 years ago

Reviewer Sheppy

irenesmith commented 5 years ago

https://developer.mozilla.org/en-US/docs/Web/Events/DOMMouseScroll - this event is a MouseScrollEvent and that has been deprecated.

https://developer.mozilla.org/en-US/docs/Web/Events/mousewheel - this is a MouseWheelEvent and that has been deprecated

https://developer.mozilla.org/en-US/docs/Web/Events/MozMousePixelScroll is a MouseScrollEvent and that has been deprecated

wbamberg commented 5 years ago

@irenesmith , can you comment on the status of this story? Is it waiting for review, or finished?

irenesmith commented 5 years ago

@wbamburg Sheppy suggested some updates. I have to go through and make sure that implemented the suggested changes on all pages. I will update after the mid-sprint meeting today.

Elchi3 commented 5 years ago

There is still an open PR that relates to this issue: https://github.com/mdn/browser-compat-data/pull/3947

irenesmith commented 5 years ago

Tracking the events as I check and implement comments:

macOS specific

These do not have examples and there is no spec to point to but the events were moved under Element.

irenesmith commented 5 years ago

All events have been checked and the following PR has been created for BCD: PR #4019

@a2sheppy Ready for second review

a2sheppy commented 5 years ago

Ignore my briefly-present comment about the locations. I see there are apparently redirects in place

a2sheppy commented 5 years ago

https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseenter_event -- The example does not work, at least in Firefox. I added code to make it use the prefixed version if available, but it still doesn't work. Claims the object being passed into the matches() method isn't an element. Weird. This needs to be fixed so the example works. Also, it should be revised to split the JavaScript, HTML, etc into separate sections like other examples do, instead of using <script>

https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseleave_event -- The example needs to be made "live" and the code split up into separate JavaScript, HTML, etc.

chrisdavidmills commented 5 years ago

https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseenter_event -- The example does not work, at least in Firefox. I added code to make it use the prefixed version if available, but it still doesn't work. Claims the object being passed into the matches() method isn't an element. Weird. This needs to be fixed so the example works. Also, it should be revised to split the JavaScript, HTML, etc into separate sections like other examples do, instead of using Githubissues.

  • Githubissues is a development platform for aggregating issues.