Closed Elchi3 closed 5 years ago
Estimate is based on 5 or 6 pages a day
Reviewer Sheppy
https://developer.mozilla.org/en-US/docs/Web/Events/DOMMouseScroll - this event is a MouseScrollEvent and that has been deprecated.
https://developer.mozilla.org/en-US/docs/Web/Events/mousewheel - this is a MouseWheelEvent and that has been deprecated
https://developer.mozilla.org/en-US/docs/Web/Events/MozMousePixelScroll is a MouseScrollEvent and that has been deprecated
@irenesmith , can you comment on the status of this story? Is it waiting for review, or finished?
@wbamburg Sheppy suggested some updates. I have to go through and make sure that implemented the suggested changes on all pages. I will update after the mid-sprint meeting today.
There is still an open PR that relates to this issue: https://github.com/mdn/browser-compat-data/pull/3947
Tracking the events as I check and implement comments:
These do not have examples and there is no spec to point to but the events were moved under Element.
All events have been checked and the following PR has been created for BCD: PR #4019
@a2sheppy Ready for second review
Ignore my briefly-present comment about the locations. I see there are apparently redirects in place
https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseenter_event -- The example does not work, at least in Firefox. I added code to make it use the prefixed version if available, but it still doesn't work. Claims the object being passed into the matches()
method isn't an element. Weird. This needs to be fixed so the example works. Also, it should be revised to split the JavaScript, HTML, etc into separate sections like other examples do, instead of using <script>
https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseleave_event -- The example needs to be made "live" and the code split up into separate JavaScript, HTML, etc.
https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseenter_event -- The example does not work, at least in Firefox. I added code to make it use the prefixed version if available, but it still doesn't work. Claims the object being passed into the matches() method isn't an element. Weird. This needs to be fixed so the example works. Also, it should be revised to split the JavaScript, HTML, etc into separate sections like other examples do, instead of using
You could always just copy the example from https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseover_event, since it includes both. I don't think the current mouseenter example is very useful anyway.
Yeah, I’ve actually fixed one or two of these, but then decided I would leave them for Irene to fix from here out. I’m just commenting on them as I go from now on, unless the problems are really minor.
On April 30, 2019 at 3:38:59 AM, Chris Mills (notifications@github.com) wrote:
You could always just copy the example from https://developer.mozilla.org/en-US/docs/Web/API/Element/mouseover_event, since it includes both. I don't think the current mouseenter example is very useful anyway.
Eric Shepherd Senior Technical Writer MDN Web Docs https://developer.mozilla.org/ Blog: https://www.bitstampede.com/
I don't mind having to fix them. Once you are done @a2sheppy, let me know and I'll go back and work through it.
@irenesmith -
https://developer.mozilla.org/en-US/docs/Web/API/Element/Activate_event -- There is no activate
event in HTML, the DOM, or any other related spec that I could find. The only one I can find is in the SVG spec, but if that's the one this is documenting, it doesn't belong under Element
but under SVGElement
, probably. Then the content needs to be straightened up to cover that better.
In addition, the example should be straightened up; the syntax is somewhat out of date judging from what I see in the SVG spec.
Other than the issues mentioned here that need to be gone over, I'm done reviewing and doing some copy edits through these articles.
There's an activate event in service workers, but that's a different thing entirely: https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/activate_event.
@a2sheppy , where did you see the SVG mention? I never saw that when I was doing the SVG events.
I had never heard of this onactivate
event either. I tried writing a quick demo to see if I could get it working on a standard link:
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>activate event test</title>
<style>
a:active {
background-color: red;
}
</style>
</head>
<body>
<h1 id="top">Top heading</h1>
<p>Some content, <a href="#second">Link to second heading</a>.</p>
<p>Some content</p>
<p>Some content</p>
<p>Some content</p>
<p>Some content</p>
<p>Some content</p>
<p>Some content</p>
<p>Some content</p>
<p>Some content</p>
<p>Some content</p>
<h2 id="second">Second heading</h2>
<script>
let link = document.querySelector('a');
link.addEventListener('activate', () => {
console.log('Link activated');
})
</script>
</body>
</html>
But no joy.
It must be an SVG thing, if it still exists; it is mentioned on https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/Events#Graphical_Event_Attributes.
@irenesmith , I'd just move this one under the SVGEvent interface and be done with it; don't waste loads of time trying to get it to work.
OK, stop the train.
I tried rewriting the SVG example on the activate page and testing it:
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>activate event test</title>
<style>
a:active {
background-color: red;
}
</style>
</head>
<body>
<svg xmlns="http://www.w3.org/2000/svg" version="1.2" baseProfile="tiny"
xmlns:ev="http://www.w3.org/2001/xml-events"
width="6cm" height="5cm" viewBox="0 0 600 500">
<desc>Example: invoke an ECMAScript function from a DOMActivate event</desc>
<!-- Act on each DOMActivate event -->
<circle cx="300" cy="225" r="100" fill="red">
</circle>
<text x="300" y="480" font-family="Verdana" font-size="35" text-anchor="middle">
Activate the circle to change its size
</text>
</svg>
<!-- ECMAScript to change the radius -->
<script>
let circle = document.querySelector('circle');
circle.addEventListener('DOMActivate', () => {
circle.setAttribute('r', '200');
})
</script>
</body>
</html>
This works in Chrome and Safari, but not in Firefox.
Then I tried changing the example in the last comment to use DOMActivate — this works in Firefox, but not in Chrome/Safari.
So it looks like we need one version of this on Element, and one on SVGElement.
And BTW, you don't need to worry about equivalent onDOMActivate pages. That doesn't seem to work anywhere.
And then I found this:
http://help.dottoro.com/ljckqjrt.php
Which says that DOMActivate only works on certain elements in certain browsers.
It has some useful examples on it. It looks like DOMActivate works on <button>
elements in all browsers.
OK, final word on this — leave the page on Element, but make sure you document in the BCD where it fires, in what browsers. And change the name to DOMActivate.
And by the way, it's defined in the UIEvents spec: https://w3c.github.io/uievents/#event-type-DOMActivate
and it's deprecated.
@chrisdavidmills Thanks! I'm working on this today and will try to get done before we meet. I've got a better-working example going for the mouseenter/mouseleave events.
Created a new example that shows both mouseenter and mouseleave. I also updated the PR. I think I'm good to go now.
@a2sheppy I know you already know that you can review the changes, but I wanted to put it here as well for tracking purposes.
Working on reviews; my feedback will go into this and following comments.
DOMActivate
; need to then make sure this event is listed in the correct place in GroupData.json
Activate
is not defined in that spec, so I removed that row from the table.Activate
. The spec table needs to be updated to instead refer to the actual place where this event is defined.auxclick
does not appear anywhere in GroupData.json
and needs to be addedGroupData.json
and needs to be added, if we intend to use this group. Otherwise, this should be put into the "DOM Events" group. It does already exist in SpecData.json
.preventDefault()
on the contexrtmenu
event, in order to keep the popup from appearing on right-click. I then added a paragraph discussing this addition.detail
property indicates the number of clicks that occurred.../oncontextmenu_event
. This needs to be fixed to .../contextmenu_event
.mouseenter
here, instead of this non-interactive, non-live example. Or make this into a live example@irenesmith - I've completed my review. The comments above list the things I think need to be dealt with and other information about what I noticed or did.
There are some things that need to be fixed or added, listed up above.
Thanks. I will go through it.
On Thu, May 9, 2019 at 11:58 AM Eric Shepherd notifications@github.com wrote:
@irenesmith https://github.com/irenesmith - I've completed my review. The comments above list the things I think need to be dealt with and other information about what I noticed or did.
There are some things that need to be fixed or added, listed up above.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mdn/sprints/issues/955#issuecomment-490963600, or mute the thread https://github.com/notifications/unsubscribe-auth/AABO6WTCEJVTIL4PSDCXZ2DPURC2FANCNFSM4GUVASIA .
tried to make the example work as a live example with no luck I'll come back to this after everything else is completed
Considering the event is deprecated, I don't think this is worth doing.
The example was the same as the one used in mouseenter but I neglected to make it live. That has been fixed.
I added a description of what is happening, including why the x and y values have to be adjusted. The other events I used in this example have the same description thanks to the macro Sheppy inserted on the page. It only made me nuts for a few minutes while I figured out what had suddenly gone wrong.
I did make the change but I really don't like the example. I'll see if I can come up with something else, perhaps something that's more useful. But I'd like to get the overall changes made and approved first.
Since this is a deprecated event, after discussion with Chris, I won't update the BCD.
These events are vendor-specific. Chris and I discussed how to handle them, and determined to follow the pattern set by Will. Unfortunately, I didn't bookmark the example I had and have asked Will to send me a link.
@a2sheppy The PR for the updated groupData.json is PR #1172 but I can't either request or assign reviewers for this Repo. Can you review and merge if it's all right?
Chris and I discussed how to handle them, and determined to follow the pattern set by Will. Unfortunately, I didn't bookmark the example I had and have asked Will to send me a link.
I'm not sure what Chris meant because I'm not Chris :), but perhaps the pattern is the one used for these: https://github.com/mdn/sprints/issues/1102#issuecomment-482359657 ?
These have:
Thank you so much!
On Mon, May 27, 2019 at 11:48 AM wbamberg notifications@github.com wrote:
Chris and I discussed how to handle them, and determined to follow the pattern set by Will. Unfortunately, I didn't bookmark the example I had and have asked Will to send me a link.
I'm not sure what Chris meant because I'm not Chris :), but perhaps the pattern is the one used for these: #1102 (comment) https://github.com/mdn/sprints/issues/1102#issuecomment-482359657 ?
These have:
- a "nonstandard" header
- a normal intro paragraph with an extra bit at the end like "It is a proprietary event specific to $browser"
- a normal blue nox
- a "Specifications" saying "Not part of any specification"
- keep the example if there is one and it is useful, otherwise don't bother
- a normal BCD (this is important)
- a normal "See Also"
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mdn/sprints/issues/955?email_source=notifications&email_token=AABO6WQNQNPGOKEC6ZG72ATPXP7FZA5CNFSM4GUVASIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKDM4Y#issuecomment-496252531, or mute the thread https://github.com/notifications/unsubscribe-auth/AABO6WUJOSAXHU7VU3DIHQLPXP7FZANCNFSM4GUVASIA .
Moving this to Lena Horne, as the PR is not yet merged. @irenesmith What help do you need to move forward?
The PR was too outdated so I've closed the original PR and created a new one:
Things that still need to be addressed:
Those webkit
ones at least need to indicate true
for Safari desktop if nothing else.
mdn_url
link in BCD:Once these BCD issues are resolved, this is all done at last!
Created a new pull request which adds the missing mouse events, exept for mousewheel which has BCD information. I also corrected the link in the contextmenu event.
This is a work item for #685.
Pages:
macOS specific
The target here is Element mostly. Some non-standard ones, we will need to see how they fit it.
Acceptance criteria