search

mdn / translated-content

The source repository of all translated content for MDN Web Docs
https://developer.mozilla.org/en-US/docs/MDN/Community/Contributing/Translated_content
Other
1.66k stars 8k forks source link

Resolve macro render errors in translated-content #13499

Open caugner opened 1 year ago

caugner commented 1 year ago

We have begun collecting build errors during our nightly builds (see also: https://github.com/mdn/translated-content/issues/12578), and with https://github.com/mdn/yari/pull/8953 we now also see where other macros fail to render:

es

fr

ja

ko

Done in #15097

pt-br

ru

zh-cn

Done in #13623

zh-tw

Done in #13550.

yin1999 commented 1 year ago

When resolving the macro render errors for zh-TW, I found that this document in en-US also has a unrendered specifications macro. @caugner maybe we should waiting for upstream fixes on some files, could you report this in mdn/content with a full collection for en-US ;)

edit: there is a PR mdn/content#27113

jasonren0403 commented 1 year ago

All macro render errors have been resolved in l10n-zh.

Graywolf9 commented 1 year ago

All macro render errors have been resolved for es

YujiSoftware commented 8 months ago

Already fixed /ja/docs/Web/HTML/Element/menuitem in #13912 .

leon-win commented 8 months ago

Do I understand correctly that to solve the problem we must remove the {{Compat}} and {{Specifications}} macros on the specified pages?

yin1999 commented 8 months ago

Do I understand correctly that to solve the problem we must remove the {{Compat}} and {{Specifications}} macros on the specified pages?

Most of them could be resolved in this way (In fact, we only need to update these sections according to the content of the en-US documents).

leon-win commented 8 months ago

I created #16995, #16996, #16997, #17020, #17022, #17026. After they are merged the described errors must be corrected. But it would be good to run the check again to see what errors there are at the moment :)

I ask for help with the review, if anyone has the opportunity :pray:

yin1999 commented 8 months ago

I created #16995, #16996, #16997, #17020, #17022, #17026. After they are merged the described errors must be corrected. But it would be good to run the check again to see what errors there are at the moment :)

I ask for help with the review, if anyone has the opportunity 🙏

It would be better to waiting for the review from the l10n-ru team. But if you've waited too long, I'm willing to help review the PR for orphan document removal.

leon-win commented 8 months ago

I created #16995, #16996, #16997, #17020, #17022, #17026. After they are merged the described errors must be corrected. But it would be good to run the check again to see what errors there are at the moment :) I ask for help with the review, if anyone has the opportunity 🙏

It would be better to waiting for the review from the l10n-ru team. But if you've waited too long, I'm willing to help review the PR for orphan document removal.

Yes, I understand and agree that it is more logical for members of the l10n-ru team to review. But unfortunately, now many of them do not have enough time for this(((

Therefore, I try to make some PRs (if possible) suitable for review by the entire community))

@yin1999, I am very grateful to you for helping wherever possible! :hugs:

leon-win commented 7 months ago

Now it should be fixed for ru, but checking would not be superfluous

hochan222 commented 5 months ago

All macro render errors have been resolved for ko.

leon-win commented 5 months ago

In the ru locale the errors are also fixed, I checked :ok_hand: