mdn / translated-content

The source repository of all translated content for MDN Web Docs
https://developer.mozilla.org/en-US/docs/MDN/Community/Contributing/Translated_content
Other
1.73k stars 8.08k forks source link

{{page}} macro removal for French pages - Meta #3881

Closed SphinxKnight closed 2 years ago

SphinxKnight commented 2 years ago

The old transclusion macro {{page}} has been removed and is not working anymore. However, it does appear in some localized pages such as spotted by @nhoizey (https://mamot.fr/@nhoizey/107694225381352679 )

I'm filing this issue as a first step before making a corrective PR.

SphinxKnight commented 2 years ago

Splitted this one in smaller issues:

cw118 commented 2 years ago

@SphinxKnight hope you don't mind me pinging — are there any sections of this that I could help with? (And just to confirm, should/can these macros be replaced with links?)

SphinxKnight commented 2 years ago

No problem at all : ) I'm assigning myself when I start working on a given issue, so feel free to tackle any other :)

This macro should be replaced with the corresponding content of the English page. This was not a "link" macro but a "transclusion" macro which injected the content of a whole page/section onto the current page. So the target is to have parity w/ en-US (sometimes it's trivial… sometimes it's not ^ ^)

That being written, thanks a lot for filing the issues for the other locales! :)

cw118 commented 2 years ago

There is now 0 {{page}} macros for l10n-fr, thank you again @SphinxKnight :)

SphinxKnight commented 2 years ago

There is now 0 {{page}} macros for l10n-fr, thank you again @SphinxKnight :)

Wooot, thanks for all the eagle-eyed reviews 🙇