search

mdn / translated-content

The source repository of all translated content for MDN Web Docs
https://developer.mozilla.org/en-US/docs/MDN/Community/Contributing/Translated_content
Other
1.69k stars 8.05k forks source link

Issue with "合作异步JavaScript: 超时和间隔": (links fail) #5018

Closed chensj-sj closed 2 years ago

chensj-sj commented 2 years ago

MDN URL: https://developer.mozilla.org/zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous_ae5a561b0ec11fc53c167201aa8af5df

What information was incorrect, unhelpful, or incomplete?

Many active learning links fail

Specific section or headline?

Active learning: reaction game

What did you expect to see?

Did you test this? If so, how?

MDN Content page report details * Folder: `zh-cn/conflicting/learn/javascript/asynchronous_ae5a561b0ec11fc53c167201aa8af5df` * MDN URL: https://developer.mozilla.org/zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous_ae5a561b0ec11fc53c167201aa8af5df * GitHub URL: https://github.com/mdn/translated-content/blob/main/files/zh-cn/conflicting/learn/javascript/asynchronous_ae5a561b0ec11fc53c167201aa8af5df/index.html * Last commit: https://github.com/mdn/translated-content/commit/8824afb494e5398bc0efcf5f7eb78782096fc90c * Document last modified: 2022-03-18T13:53:46.000Z
很多主动学习的链接失效 #### Specific section or headline? #### What did you expect to see? #### Did you test this? If so, how?
MDage report details * Folder: `zh-cn/conflicting/learn/javascript/asynchronous_ae5a561b0ec11fc53c167201aa8af5df` * MDN URL: https://developer.mozilla.org/zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous_ae5a561b0ec11fc53c167201aa8af5df * GitHub URL: https://github.com/mdn/translated-content/blob/main/files/zh-cn/conflicting/learn/javascript/asynchronous_ae5a561b0ec11fc53c167201aa8af5df/index.html * Last commit: https://github.com/mdn/translated-content/commit/8824afb494e5398bc0efcf5f7eb78782096fc90c * Document last modified: 2022-03-18T13:53:46.000Z
yin1999 commented 2 years ago

This document has been removed from mdn/content via commit: https://github.com/mdn/content/commit/7cf00aff32962e6135132531d699f4d21667f376

In en-US, the URI Learn/JavaScript/Asynchronous/Timeouts_and_intervals has been redirected to Learn/JavaScript/Asynchronous. but in pt-BR, ru, zh-CN, zh-TW, fr, the URI has been redirect to conflicting/Learn/JavaScript/Asynchronous_ae5a561b0ec11fc53c167201aa8af5df. It seems ok in ko.

@cw118 should we deal with this difference ?

cw118 commented 2 years ago

Thanks for letting us know @yin1999. You're definitely more than welcome to at least fix this particular conflicting page in zh-CN/TW.

That being said, each locale tends to deal with conflicting files differently in my experience so I'm not sure about the rest of the locales; for example, l10n-fr doesn't really consider it a priority but we are currently working on taking care of conflicting and will fix this on our end soon.

yin1999 commented 2 years ago

@irvin Is it ok to resolve with the redirects I have made in #5024

irvin commented 2 years ago

@irvin Is it ok to resolve with the redirects I have made in #5024

@yin1999 please un-draft that PR once you are ready, thanks

yin1999 commented 2 years ago

@irvin ready for merge

irvin commented 2 years ago

@yin1999 can you also remove this conflict file and set a redirect from it to the correct version? (try https://github.com/mdn/content#deleting-a-document )

remove: https://developer.mozilla.org/zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous_ae5a561b0ec11fc53c167201aa8af5df redirect to: /zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous

yin1999 commented 2 years ago

@irvin Is it ok to resolve with the redirects I have made in #5024

@yin1999 please un-draft that PR once you are ready, thanks

Done in 05f8d31a914193c65cbe501fc6edb1db7f29ae05

irvin commented 2 years ago

@yin1999 i think we can also remove /zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous and redirect to /zh-CN/docs/Learn/JavaScript/Asynchronous

yin1999 commented 2 years ago

Hi @irvin if we need to remove /zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous, the other two documents should also be removed (or it cannot be processed):

If you think it's ok, I'll remove those three documents.

irvin commented 2 years ago

Hi @irvin if we need to remove /zh-CN/docs/conflicting/Learn/JavaScript/Asynchronous, the other two documents should also be removed (or it cannot be processed):

  • conflicting/Learn/JavaScript/Asynchronous/Promises
  • conflicting/Learn/JavaScript/Asynchronous/Introducing

If you think it's ok, I'll remove those three documents.

sure

yin1999 commented 2 years ago

It seems that google and other crawler will not index the documents in conflicting, maybe it's ok for us to just resolve those URI which has been redirected to conflicting. (sitemap of mdn: https://developer.mozilla.org/sitemap.xml, it has been include in robots.txt)

And I have searched on google for the conflict documents, it seems that the documents are not visiable for google:

image

@irvin Any idea?

yin1999 commented 2 years ago

I've push the commit 41717be4b1327857218652323d177a20612999f2 to deal with removing conflict documents in Learn/JavaScript/Asynchronous.