mdn / yari

The platform code behind MDN Web Docs
Mozilla Public License 2.0
1.19k stars 507 forks source link

gradient formal syntax is missing conic-gradient() and <repeating-conic-gradient()> #10963

Open estelle opened 6 months ago

estelle commented 6 months ago

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/gradient

What specific section or headline is this issue about?

formal syntax

What information was incorrect, unhelpful, or incomplete?

conic and repeating conic gradients are missing

What did you expect to see?

six gradient values in syntax (there are only four)

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details * Folder: `en-us/web/css/gradient` * MDN URL: https://developer.mozilla.org/en-US/docs/Web/CSS/gradient * GitHub URL: https://github.com/mdn/content/blob/main/files/en-us/web/css/gradient/index.md * Last commit: https://github.com/mdn/content/commit/745950224a21606bb2d953e149b1385b9ea6a3f8 * Document last modified: 2024-01-11T13:30:51.000Z
caugner commented 6 months ago

This looks like a yari issue. It might be a limitation of yari itself or @webref/css doesn't include those values yet.

Actual

<gradient> = 
  <linear-gradient()>            |
  <repeating-linear-gradient()>  |
  <radial-gradient()>            |
  <repeating-radial-gradient()>

Expected

<gradient> = 
  <linear-gradient()>            |
  <repeating-linear-gradient()>  |
  <radial-gradient()>            |
  <repeating-radial-gradient()> |
  <conic-gradient()> |
  <repeating-conic-gradient()>
fiji-flo commented 6 months ago

This is not straight forward. It's in webref (https://github.com/w3c/webref/blob/418f3cf1e8ea1aaaec479ce18b739edb556ee7e3/ed/css/css-images-4.json#L167).

Fairly sure it's this line https://github.com/mdn/yari/blob/37379ecca00b5100040485987bb6541626614066/kumascript/src/lib/css-syntax.ts#L139

I'm working an CSS Syntax as part of our build system refactoring and will address this in there.

wbamberg commented 6 months ago

See also https://github.com/orgs/mdn/discussions/442. This is about ensuring the different parts of a CSS reference page (especially Syntax, Formal Syntax, and BCD) are consistent with each other, and is quite complicated.