mdn / yari

The platform code behind MDN Web Docs
Mozilla Public License 2.0
1.16k stars 486 forks source link

chore(macros/LearnSidebar): add Japanese translation for 4 locations #11351

Closed gurezo closed 1 week ago

gurezo commented 1 week ago

Summary

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

Problem

still en-us only

English pages

Japanese pages

English pages Japanese pages
スクリーンショット 2024-06-22 13 32 04 スクリーンショット 2024-06-22 13 40 13
スクリーンショット 2024-06-22 13 31 49 スクリーンショット 2024-06-22 13 40 45

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@caugner, @wbamberg , @schalkneethling

Please merge once mdn-yari-ja is approved.

Before

still en-us only

After

add tranlate japanese for LearnSidebar.ejs

gurezo commented 1 week ago

@caugner, @wbamberg , @schalkneethling

already approved by mdn-yari-ja (@potappo) please this PR review

caugner commented 1 week ago

Thanks @gurezo!

PS: In the future, I recommend to mention @mdn/core-dev only, because a review from this team is required for the merge.

gurezo commented 1 week ago

Hi @caugner thanks for reprely, ok next time i will send @mdn/core-dev team!