mdn / yari

The platform code behind MDN Web Docs
Mozilla Public License 2.0
1.16k stars 486 forks source link

Yari build possibly broken #11365

Closed estelle closed 6 days ago

estelle commented 1 week ago

Summary

I updated my local environment. I can get to http://localhost:5042/en-US/docs (which redirects to http://localhost:5042/en-US/docs/Web) but not to http://localhost:5042 or http://localhost:5042/en-US or http://localhost:5042/en-US/play/ (live examples work, but clicking "play" to open in new tab gets the error)

The error message reads:

Error: ENOENT: no such file or directory, stat 'myPath/content/node_modules/@mdn/yari/client/build/en-us/_spas/404.html'

It was working on 2.56, but the 2.57 build seems to be the issue.

URL

http://localhost:5042

Reproduction steps

  1. update all the repose
  2. yarn install; yarn start
  3. go to the local environment's MDN home page.

Expected behavior

the home page

Actual behavior

an error: Error: ENOENT: no such file or directory

Device

Desktop

Browser

Edge

Browser version

Stable

Operating system

iOS

Screenshot

Screenshot 2024-06-25 at 11 47 19 AM

Screenshot 2024-06-25 at 11 48 05 AM

Anything else?

No response

Validations

caugner commented 1 week ago

Technically, we're missing a yarn render:html when packaging yari, but originally it seems yarn tool spas no longer building HTML files is a breaking change we missed. We'll provide a fix in the next 24 hours.

caugner commented 6 days ago

@estelle The fix is now available in @mdn/yari 2.58.0, and I expect Dependabot to open a PR on mdn/content in the next hours.

caugner commented 6 days ago

With https://github.com/mdn/content/pull/34426 being merged, the fix has now landed in the content repository.

estelle commented 6 days ago

@caugner Thanks for the quick turn around and fix. It's working