mdn / yari

The platform code behind MDN Web Docs
Mozilla Public License 2.0
1.19k stars 509 forks source link

Suggestion: Remove a title in the `[]()` syntax in markdown. (h2m converter) #4320

Closed hochan222 closed 2 years ago

hochan222 commented 3 years ago

I had a question while converting html to markdown in that PR.

<a href="http://www.google.com/search?q=javascript+module+pattern" title="http://www.google.com/search?q=javascript+module+pattern">모듈 패턴</a>

I have seen the following code convert as follows.

[모듈 패턴](http://www.google.com/search?q=javascript+module+pattern "http://www.google.com/search?q=javascript+module+pattern")

That grammar was an existing grammar in GFM.

However, I think there is a disadvantage that can be obtained by additionally specifying the title in markdown []().

This is contrary to the reasons for adopting the markdown approach. OWD project: convert MDN content to Markdown

Why do we need a title?

wbamberg commented 3 years ago

Good suggestion, @hochan222 ! I agree that we should remove title attributes from links.

peterbe commented 3 years ago

If you see

<a href="http://www.google.com/search?q=javascript+module+pattern" title="http://www.google.com/search?q=javascript+module+pattern">모듈 패턴</a>

I think you can safely replace it with

<a href="http://www.google.com/search?q=javascript+module+pattern">모듈 패턴</a>