use different sub-domain to deploy a PR preview for `translated-content`

mdn / yari

The platform code behind MDN Web Docs

Mozilla Public License 2.0

1.18k stars 503 forks source link

use different sub-domain to deploy a PR preview for `translated-content` #7868

Open yin1999 opened 1 year ago

yin1999 commented 1 year ago

We use content.dev.mdn.mozit.cloud to deploy PR preview for both mdn/content and mdn/translated-content repos. So the new PR which may create a new deployment that overrides the deployment in content.

Now, the PR number in translated-content grows to 10762 while the oldest PR that haven't been merged in content is mdn/content#11817. We may have conflict in the future.

yin1999 commented 1 year ago

Maybe we could use different prefix for mdn/content and mdn/translated-content. It seems to be a easier way.

caugner commented 2 months ago

I believe this is no longer a practical issue, because mdn/content is at 34387, while mdn/translated-content is at 21913.

@yin1999 What do you think?

yin1999 commented 2 months ago

I believe this is no longer a practical issue, because mdn/content is at 34387, while mdn/translated-content is at 21913.

We should compare the oldest unclosed PR in mdn/content with the latest PR in mdn/translated-content, so it should be "mdn/content#26431 vs mdn/translated-content#21913".

Of course, it seems that this problem has been temporarily alleviated :)

Maybe we can use different prefixes for PRs in those repositories. But I'm not sure if this is technically easy (whether it would involve a lot of code changes).

caugner commented 2 months ago

Maybe we can use different prefixes for PRs in those repositories.

Yes, you're right, it looks like a one-line change here: