Changing focus from the search box causes top result to not work

LeoMcA commented 1 year ago

Summary

Using tab to change focus from the search box (which could happen relatively often if one assumes [like me] that's how to select one of the results), then shift tab to go back causes the top result to be nonfunctional.

URL

https://developer.mozilla.org/

Reproduction steps

Click on the input box
Type a query
Press Tab to change focus to the cancel button
Press Shift + Tab to change focus back to the input
Press Down to highlight the first result
Press Return to navigate to it - nothing happens
Click on the result - nothing happens

Expected behavior

Hitting return or clicking on the top result causes it to open.

Actual behavior

Nothing happens.

Device

Desktop

Browser

Firefox

Browser version

Pre-release (e.g. Beta, Nightly or Canary)

Operating system

Linux

Screenshot

No response

Anything else?

https://github.com/mdn/yari/pull/7979#issuecomment-1438155090

Validations

[X] I have read the Community Participation Guidelines.
[X] I have verified that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] I have checked that this is a concrete bug. For Q&A open a GitHub Discussion.

kemilbeltre commented 1 year ago

Hi @LeoMcA, I'm probably missing something, but why press Return and not Enter to navigate to the highlighted result? Thanks

kemilbeltre commented 1 year ago

Hi @LeoMcA, I'm probably missing something, but why press Return and not Enter to navigate to the highlighted result? Thanks

These keys are different and I think you need to use shift + Return or ctrl + Return to confirm.

caugner commented 2 months ago

@LeoMcA I cannot reproduce this issue, could you please check if you can?

PS: I have already experienced a different quick search issue, wherein the quick search no longer shows any results when going back to an MDN tab after some time, see: https://github.com/mdn/yari/issues/11181

mdn / yari