search

mdnsfr / docker-rancher-openvpn

OpenVPN Server with optionnal Rancher specific abilities, with multiple authentication backends
59 stars 32 forks source link

Multiline OPENVPN_EXTRACONF #4

Closed JStumpp closed 8 years ago

JStumpp commented 8 years ago

The OPENVPN_EXTRACONF should accept multiple lines (e.g. separated with \n)

and the default configuration parameters should be removed from bin/entry.sh to be usable in general:

Thanks for the nice container!

AlexisDucastel commented 8 years ago

This makes sense ! I'll add something in this way for multiline extraconfig in next days.

default configuration parameters should be removed from bin/entry.sh to be usable in general

Just to be sure, you suggest to introduce new environment variables to be able to customize these default parameters ?

Thanks for your help.

JStumpp commented 8 years ago

Yes, environment variables for the stuff that is always required: push "dhcp-option DNS $DNS" push "dhcp-option SEARCH $SEARCH" push "route $ROUTE_NETWORK $ROUTE_NETMASK"

But the second route you defined I would move to the OPENVPN_EXTRACONF: push "route 169.254.169.250 255.255.255.255"

Than it can be used as standalone without rancher as well.

Thanks!

AlexisDucastel commented 8 years ago

Done !

https://github.com/mdnsfr/docker-rancher-openvpn/commits/master new docker image available : 1.2 https://hub.docker.com/r/mdns/rancher-openvpn/tags/

JStumpp commented 8 years ago

Wonderful, thanks!