mdolab / .github

0 stars 3 forks source link

Update black version #31

Closed A-CGray closed 2 years ago

A-CGray commented 2 years ago

Purpose

Today one of black's dependencies, click, made some breaking changes that broke black. They released a fix but to get it we need to update to black v22.3.0, otherwise all of our black formatting checks that are run with GHA will fail. The other option is to pin click<8.1.0 but that feels like a bad approach.

Expected time until merged

Type of change

Testing

Checklist

ewu63 commented 2 years ago

Is there really no way to use the older version? Feels kinda nuts that all previous versions of black can no longer be used. I guess the way to bypass this is to not use the GHA but instead manually downgrade click or something.

I'm just hesitant to update because there are formatting changes with 22 which means this would probably fail all the existing formatting in all repos. I guess I'm okay with bumping this but we have to be careful in updating this + getting everyone to update black on their machines.

A-CGray commented 2 years ago

My reading of the PR I linked to is that it's either upgrade to 22.3 or pin an old version of click, I could be misunderstanding though

A-CGray commented 2 years ago

Looks like this is now causing a failure in the azure jobs too