mdolab / .github

0 stars 3 forks source link

Use global .clang-format file and format all files #34

Closed A-CGray closed 2 years ago

A-CGray commented 2 years ago

Purpose

I was about to add clang-format to the RLT repo and realised it was stupid to copy the same .clang-format and clang-format.sh files across multiple repos so I just moved them here. Personally I don't have an issue with running clang-format on all C/C++ files in a repo (rather than just those in a src/ directory) but I'm open to dissenting opinions

Expected time until merged

End of this week (3 days)

Type of change

Testing

Checklist

A-CGray commented 2 years ago

@eirikurj sorry to bug but I'd like to get your blessing before merging this

eirikurj commented 2 years ago

Looks good. Seems to be copied over from tacs_orig with the hpp and cpp additions. Not that its critical, but do we need the hpp extension. Cant recall any repo of ours that uses that extension? I will make a PR to update tacs_orig to use this.

eirikurj commented 2 years ago

PR https://github.com/mdolab/tacs_orig/pull/86 is up and can be merged once we clarify the extensions. I expect you have the RLT repo already done?

A-CGray commented 2 years ago

Looks good. Seems to be copied over from tacs_orig with the hpp and cpp additions. Not that its critical, but do we need the hpp extension. Cant recall any repo of ours that uses that extension? I will make a PR to update tacs_orig to use this.

Yeah I copied from tacs_orig, I added .hpp just for future-proofing