Added fprettify job - Githubissues

mdolab / .github

0 stars 3 forks source link

Added fprettify job #37

Closed sseraj closed 2 years ago

sseraj commented 2 years ago

Purpose

This adds a job for fprettify that we can use to style check our Fortran codes.

Expected time until merged

I will probably just merge this tomorrow and then push directly to main to iterate on any fixes, but comments are welcome.

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[ ] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation

marcomangano commented 2 years ago

Looks good, I assume there is no equivalent --dry-run arg or a direct exit code for this tool so we have to rely on git diff?

sseraj commented 2 years ago

Looks good, I assume there is no equivalent --dry-run arg or a direct exit code for this tool so we have to rely on git diff?

That's correct. There is no built-in check functionality.