Ignore W503 - Githubissues

mdolab / .github

0 stars 3 forks source link

Ignore W503 #38

Closed A-CGray closed 2 years ago

A-CGray commented 2 years ago

Purpose

flake8 currently flags code like this as wrong due to a line break before a binary operator (the + symbol):

income = (gross_wages
          + taxable_interest)

However, by flake8's own admission, this is actually considered best practice by PEP.

We should therefore ignore W503 to remove these warnings

Expected time until merged

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[ ] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

A-CGray commented 2 years ago

Turns out W503 should already be ignored by default, there must be something wrong with my local setup