Remove TACC images from test matrix - Githubissues

mdolab / .github

0 stars 3 forks source link

Remove TACC images from test matrix #65

Closed eirikurj closed 8 months ago

eirikurj commented 8 months ago

Purpose

TACC Stampede2 images are outdated and will not be built past PR https://github.com/mdolab/docker/pull/264. This PR removes them from the testing matrix.

Expected time until merged

No rush.

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

marcomangano commented 8 months ago

This looks good. Do we want to add another image to the matrix or just cut it down to three images?

I think we could add u20-latest for now, and then maybe change it for a u24-latest later in the year?

A-CGray commented 8 months ago

This looks good. Do we want to add another image to the matrix or just cut it down to three images?

I think we could add u20-latest for now, and then maybe change it for a u24-latest later in the year?

Sure, feel free to open another PR for that