Closed A-CGray closed 2 years ago
Presumably we should bump the version with this PR too? Should we go to 1.2 or 2.0?
Presumably we should bump the version with this PR too? Should we go to 1.2 or 2.0?
I'd argue for 2.0 since it's an entirely new (breaking) interface. Breaking if we remove the old class, which Bernardo was suggesting.
I will review this by the end of this week.
:exclamation: No coverage uploaded for pull request base (
main@383cf16
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage ? 78.36%
=======================================
Files ? 4
Lines ? 564
Branches ? 0
=======================================
Hits ? 442
Misses ? 122
Partials ? 0
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
I will most likely not have time to review this until possibly July. I'm assuming this is not blocking anyone right?
I will most likely not have time to review this until possibly July. I'm assuming this is not blocking anyone right?
No I don't think it'll be blocking anyone, but if it's too much we can have someone else review it instead!
I have not reviewed the PR yet, but with regards to the test failing, are we going to rename the actual repository too? I would guess that Azure needs a "reset" to relink with the new URL. I think we have to delete the old pipeline and make a new one.
Unless someone disagrees, we don't have much to lose doing that through this PR.
I have not reviewed the PR yet, but with regards to the test failing, are we going to rename the actual repository too? I would guess that Azure needs a "reset" to relink with the new URL. I think we have to delete the old pipeline and make a new one.
Unless someone disagrees, we don't have much to lose doing that through this PR.
I think renaming the repo on GitHub makes sense. Let's give it a shot
Purpose
This PR adds an aero solver API for pyXLIGHT that allows it to be used in a similar manner to ADflow.
It also renames pyXLIGHT to CMPLXFOIL (let me know what needs to be changed to fix the automated testing, docs, github repo, and other maintenance stuff).
https://github.com/mdolab/pygeo/pull/141 needs to be merged first because some new CMPLXFOIL tests use
DVGeometryCST
.TODO's before this can be merged:
pyXLIGHT.py
interfaceType of change
What types of change is it? Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.