Fix plotting and update niceplots commands

eytanadler commented 1 year ago

Purpose

The matplotlib imports worked only sometimes, which this PR fixes. The error was because import matplotlib does not import pyplot automatically, so the pyplot attribute was unavailable when it was requested from matplotlib.

The second change is that the niceplots interface has been changed in version 2, so I updated it here (and the minimum version in setup.py).

Expected time until merged

Instantaneously

Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[x] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

Checklist

[ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[ ] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

codecov[bot] commented 1 year ago

Codecov Report

Merging #21 (5a7d438) into main (d5dad00) will increase coverage by 0.13%. The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   78.36%   78.50%   +0.13%     
==========================================
  Files           4        4              
  Lines         564      563       -1     
==========================================
  Hits          442      442              
+ Misses        122      121       -1

Impacted Files	Coverage Δ
cmplxfoil/CMPLXFOIL.py	`83.72% <50.00%> (+0.17%)`	:arrow_up:
cmplxfoil/__init__.py	`66.66% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bernardopacini commented 1 year ago

Broader question: is it worth moving the airfoil plotting to a different file?

A-CGray commented 1 year ago

Broader question: is it worth moving the airfoil plotting to a different file?

I think no, given that there's only one plotting function atm, but in future we add more then maybe

eytanadler commented 1 year ago

Broader question: is it worth moving the airfoil plotting to a different file?

IMO it's nice to be able to do this:

funcs = {}
CFDSolver(ap)
CFDSolver.evalFunctions(ap, funcs)
CFDSolver.plotAirfoil()

There is a separate file for generating animations if you so desire Coach B.

mdolab / CMPLXFOIL