Closed eytanadler closed 2 months ago
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 66.19%. Comparing base (
7b16ff9
) to head (b4070f8
).
Files | Patch % | Lines |
---|---|---|
cmplxfoil/__init__.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is it at all possible to add a test for this new behaviour? Or is it not possible to recreate a case where IBLPAN
fails?
If it ever hits a STOP
in Fortran, it will kill the program. That means that if the test ever fails, it won't be caught as a test failure and instead will kill the whole testing process. I can probably recreate a case, but if it fails it'll be very difficult to debug. Is that worth it? I think the fact that other regression tests still pass is a good sign that I haven't changed the underlying implementation.
On another note, do you have any idea what's wrong with readthedocs at first glance?
Purpose
With particularly bad airfoil shapes, the
IBLPAN
function fails. Upon failure, it calls theSTOP
command. This kills not only the XFOIL instance, but also the whole Python script (not good during optimization...).This PR removes the
STOP
command, instead setting fail flags accordingly and cleanly exiting back to the Python layer.I also uncommented the residual printout in the real version of CMPLXFOIL so that the user gets some feedback on convergence behavior during the primal solve.
Expected time until merged
Now!
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable