Closed bernardopacini closed 3 years ago
With regards to standardizing the repo with a config.mk
file and testing, I think we can fix up the configuration files in this PR (as they are related to setup and installation) but I would hold off on Azure and instead implement that as its own PR. Is this okay with you @nwu63? If yes, I'll go ahead and update the config file structure.
With regards to standardizing the repo with a
config.mk
file and testing, I think we can fix up the configuration files in this PR (as they are related to setup and installation) but I would hold off on Azure and instead implement that as its own PR. Is this okay with you @nwu63? If yes, I'll go ahead and update the config file structure.
I went ahead and made these changes. The build process is similar to the one used for ADflow, but simplified given that it is a smaller / more simple code.
With regards to standardizing the repo with a
config.mk
file and testing, I think we can fix up the configuration files in this PR (as they are related to setup and installation) but I would hold off on Azure and instead implement that as its own PR. Is this okay with you @nwu63? If yes, I'll go ahead and update the config file structure.
I'm fine with implementing Azure (and converting the existing test to use unittest
) in a later PR.
Purpose
This PR reorganizes the pyXLIGHT package to make it easier to build, install, and use (Issue #2). The code is not significantly changed besides adjusting how modules are setup and imported.
This PR also does not address complexifying the code.
Type of change
What types of change is it? Select the appropriate type(s) that describe this PR
Testing
Moved functionality test to
tests/
directoryChecklist
Put an
x
in the boxes that apply.