mdolab / MACH-Aero

MACH: MDO of Aircraft Configurations with High fidelity
112 stars 53 forks source link

Edited plotting file to cater for all the optimizers. Added a main fu… #158

Closed umarsajjad1992 closed 3 months ago

umarsajjad1992 commented 3 months ago

Purpose

Update the plotting file for optimization history to cater for all the optimizers in the current version

Description

Expected time until merged

The PR is not urgent as, but a week should be enough for review and merging.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

Testing

run the code:

python plot_optHist.py --histFile output/opt.hst --outputDir output/ --opt "SNOPT"

try changing the --opt argument to either "SLSQP" or "IPOPT"

Checklist

ewu63 commented 3 months ago

I'm pretty sure the failure is just because we're running SNOPT tests and this is a PR submitted by an external contributor without access to that optimizer (hence this PR...ironically). May want to add skiptest or something similar to what we do with pyOptSparse tests.

marcomangano commented 3 months ago

I'm pretty sure the failure is just because we're running SNOPT tests and this is a PR submitted by an external contributor without access to that optimizer (hence this PR...ironically). May want to add skiptest or something similar to what we do with pyOptSparse tests.

You were right, the ESP test was missing the skiptest. Merging the PR once I verify that the tests pass.