This PR addresses #244. Symmetric wings can now be used with the aerodynamics solver if they lie in the right side of the symmetry plane. Prior to this, OAS only gave correct results for left wings.
Expected time until merged
a week
Type of change
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[ ] Maintenance update
[ ] Other (please describe)
Testing
This fix can be tested by taking a standard left wing model and flipping the y nodes a shown below:
# Flip left wing to lie on right of symmetry plane
mesh[:, :ny, :] = inputs[mesh_name]
mesh[:, ny+1:, :] = inputs[mesh_name][:, ::-1, :]
mesh[:, ny+1:, 1] *= -1.
The new flipped surface can be passed to the aerodynamic component and should give a consistent solution to a left wing or full wing model.
Checklist
[x] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[x] I have run unit and regression tests which pass locally with my changes
[x] I have added new tests that prove my fix is effective or that my feature works
Purpose
This PR addresses #244. Symmetric wings can now be used with the aerodynamics solver if they lie in the right side of the symmetry plane. Prior to this, OAS only gave correct results for left wings.
Expected time until merged
a week
Type of change
Testing
This fix can be tested by taking a standard left wing model and flipping the y nodes a shown below:
The new flipped surface can be passed to the aerodynamic component and should give a consistent solution to a left wing or full wing model.
Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted