mdolab / OpenAeroStruct

OpenAeroStruct is a lightweight tool that performs aerostructural optimization using OpenMDAO.
Apache License 2.0
175 stars 112 forks source link

Docs update: solvers and parallel multipoint analysis #405

Closed kanekosh closed 1 year ago

kanekosh commented 1 year ago

Purpose

NOTE: the MPI test does not work with the oldest python/package versions, and I could not fix that. For now, we only run the MPI test on the latest and not on the oldest. This is why the yml looks a little messy.

Expected time until merged

A week

Type of change

Testing

I added a new regression test test_multipoint_parallel.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #405 (32a435e) into main (966f8dc) will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   94.47%   94.52%   +0.04%     
==========================================
  Files         103      103              
  Lines        6412     6412              
==========================================
+ Hits         6058     6061       +3     
+ Misses        354      351       -3     

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kanekosh commented 1 year ago

@eytanadler Thanks for catching a lot of types and errors! No idea about the OM installation error, I'll look into the details this week

eytanadler commented 1 year ago

@eytanadler Thanks for catching a lot of types and errors! No idea about the OM installation error, I'll look into the details this week

Sounds good! I'm also not sure what's going on with the RTD build, especially since it worked initially for this PR and you haven't changed anything since.

eytanadler commented 1 year ago

If you don't mind, could you also bump the codecov action to v3 in the github actions file in this PR? Seems like there have been recurring problems recently (but not always), and updating the action might help.