Ref axis - Githubissues

lucaeros commented 10 months ago

Purpose

Following the previous PR on chord_scaling_pos, the aim of this PR is to add a new setting called "ref_axis_pos" (stands for reference axis position) that is generalizing the "chord_scaling_pos" for every geometric transformation that needed it : twist (rotate), span (stretch), taper, chord (scaleX). Setting the ref_axis_pos, the user can decide around with reference line the geometric variable will be applied, ref_axis_pos = 0.25 is the quarter of chord and was the default one. ref_axis_pos = 1 is around the trailing edge, ref_axis_pos = 0 is around leading edge.

Expected time until merged

a week

Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[x] Documentation update
[ ] Maintenance update
[ ] Other (please describe)

Testing

Verified that the geometric variable have the correct behavior on simple cases (opt_chord.py, opt_twist.py)

Checklist

[x] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
[ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
[x] I have run unit and regression tests which pass locally with my changes
[x] I have added new tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation

eytanadler commented 10 months ago

Please add sudo apt-get update to the beginning of the Install OpenVSP step in the GitHub Actions workflow. Hopefully this will fix the 404 error preventing the actions from properly installing packages. Including the apt update is noted here, which is linked to from a GitHub issue about a similar problem.

codecov[bot] commented 10 months ago

Codecov Report

Merging #413 (e95326d) into main (5ebabd1) will increase coverage by 0.00%. The diff coverage is 98.61%.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         103      103           
  Lines        6445     6448    +3     
=======================================
+ Hits         6091     6094    +3     
  Misses        354      354

Files Changed	Coverage Δ
openaerostruct/geometry/geometry_mesh.py	`98.63% <83.33%> (-0.06%)`	:arrow_down:
openaerostruct/__init__.py	`100.00% <100.00%> (ø)`
...rostruct/geometry/geometry_mesh_transformations.py	`99.67% <100.00%> (+<0.01%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more