mdolab / adflow

ADflow is a finite volume RANS solver tailored for gradient-based aerodynamic design optimization.
Other
229 stars 100 forks source link

Update to Tapenade 3.16 #312

Closed eirikurj closed 1 year ago

eirikurj commented 1 year ago

Purpose

This PR updates the AD'd files to the latest Tapenade version along with the latest ADFirstAidKit files.

Few things to note, regarding this version of Tapenade. This version creates nonstandard type declarations, so postprocessing steps are added in autoEdit scripts. Additionally, Tapenade seems for some reason to miss the etot_d function in inviscidupwindflux_d (same for reverse) so its added back.

Please review carefully and preferably run and test this on actual cases (aside from the unit/regression tests) to make sure derivatives have not regressed in some edge cases.

Expected time until merged

No rush

Type of change

Testing

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #312 (8bf7aab) into main (686d096) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          13       13           
  Lines        4001     4001           
=======================================
  Hits         1680     1680           
  Misses       2321     2321           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more