Closed eytanadler closed 8 months ago
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 41.47%. Comparing base (
de01140
) to head (83121a7
).
Files | Patch % | Lines |
---|---|---|
adflow/mphys/mphys_adflow.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose
In the MPhys wrapper, there is an option to try clean restarting an analysis that stalls/fails to converge. In those cases, the failed solution is written so the user can try to figure out what went wrong. However, no failed solution is written when
restart_failed_analysis
is False (this is the default), making diagnosis challenging. This PR changes it so a solution is written in this case.Expected time until merged
A few days
Type of change
Testing
Run an MPhys ADflow case where the
restart_failed_analysis
option in theADflowBuilder
is set toFalse
and set the max number of ADflow iterations to a very small number so it fails to converge. Before this PR, you will see no failed analysis solution written. With the PR, you will.Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable