Closed eytanadler closed 8 months ago
Attention: Patch coverage is 0%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 41.45%. Comparing base (
572f2bf
) to head (db303c0
).
Files | Patch % | Lines |
---|---|---|
adflow/mphys/mphys_adflow.py | 0.00% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose
Failed solutions in the MPhys wrapper currently all use the same
baseName
. If you are doing multipoint and have separate analyses whose solutions fail, they will overwrite each other. For example, the first cruise analysis failure file would be called "analysis_fail_000_surf.plt". If a top of climb case later fails, it will write a file with the same name, overwriting the cruise failure.This PR adds the
AeroProblem
name to the failed solution file name, so instead of "analysis_fail_000_surf.plt", it would be "cruise_analysis_fail_000_surf.plt". This fixes the overwriting problem.Expected time until merged
A day
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable