Closed marcomangano closed 3 years ago
So I am a tiny bit uneasy about fixing complexify.py
just because it's so old it needs a total overhaul. What I would recommend is reverting those files to how they were, and if you add a .flake8
file just to ignore those files, then Travis will work its magic. We can fix these at a later date.
See for example this file.
So I am a tiny bit uneasy about fixing
complexify.py
just because it's so old it needs a total overhaul. What I would recommend is reverting those files to how they were, and if you add a.flake8
file just to ignore those files, then Travis will work its magic. We can fix these at a later date.See for example this file.
Yeah, I was a bit uneasy too but I gave it a shot. I will revert it back as you suggest
I will fix complexify
by the end of the day
Sure, instead of reverting commits you can just copy/paste what we had before and do a single commit that way.
Sure, instead of reverting commits you can just copy/paste what we had before and do a single commit that way.
That's the only way I am able to do it ahaha
@nwu63 this should fix it?
Good except you still need to run black
on it
Few minor things, otherwise looks good. Do we want to add the black/flake8 commit to a git blame ignore file?
@nwu63 what is our final position on this? I have one I can add now, but we realized that such file is only useful locally.. other ppl must initialize it in their git option for it to work, and still it is not effective on the browser interface. Your call guys!
Yeah personally I don't see much value in it since git cannot pick it out automatically, and it just sort of clutters the repo. Most tools can git blame
multiple times and as long as your commit message is clear I think it's fine.
Purpose
I re-formatted the code, as per this issue. The first two commits are the
black
and manualflake8
fixes respectively. I committed separately a few fixes that I would like the reviewers to double check carefully, to be sure that the code behaviour is not changingType of change
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted