mdolab / idwarp

IDWarp is a mesh warping package for the MACH framework.

Other

17 stars 29 forks source link

Fortran standard to 2008 #53

Closed gawng closed 3 years ago

gawng commented 3 years ago

Purpose

The Fortran standard is 2008 because petsc wasn't cooperating with earlier standards.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (non-backwards-compatible fix or feature)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Documentation update
[x] Maintenance update
[ ] Other (please describe)

Testing

I do not have complex IDWarp compiled, so those tests were skipped.

Checklist

Put an x in the boxes that apply.

[ ] I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
[x] I have run unit and regression tests which pass locally with my changes
[ ] I have added new tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation

ewu63 commented 3 years ago

I'm not 100% convinced we want to manually update the ADFirstAidKit stuff. A couple options here:

do what's currently done in the PR, and then submit a patch upstream
fix this here, but then refactor and move into a separate package (since multiple repos use the same code)
modify the rules so we don't apply new Fortran standard here

Let's talk about this during the next maintenance meeting maybe.

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (e911a6b) into master (136b3bb) will decrease coverage by 0.06%. The diff coverage is n/a.

:exclamation: Current head e911a6b differs from pull request most recent head f43c669. Consider uploading reports for the commit f43c669 to get more accurate results

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   46.13%   46.06%   -0.07%     
==========================================
  Files           6        6              
  Lines         776      775       -1     
==========================================
- Hits          358      357       -1     
  Misses        418      418

Impacted Files	Coverage Δ
idwarp/MExt.py	`97.36% <0.00%> (-0.07%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 136b3bb...f43c669. Read the comment docs.

ewu63 commented 3 years ago

How does this look @eirikurj @bernardopacini? I added a new flag for F77 code which omits the standard specification. The flags can probably be simplified (we probably don't need PETSc/CGNS since it's just the Tapenade code).

I also see that @gang525 updated the complexify module. I assume this is unavoidable since we do not have a centralized complexify package (yet) and this is OK here. We will of course have to do the same thing for other repos that use the same module (but potentially have slightly different code).