mdolab / idwarp

IDWarp is a mesh warping package for the MACH framework.
Other
17 stars 29 forks source link

Implemented aExp and bExp options #64

Closed sseraj closed 2 years ago

sseraj commented 2 years ago

Purpose

Closes #40. Please see the issue for some discussion on the performance penalty compared to hard-coded values for the exponents.

Type of change

Testing

I plan to add a test with non-default exponents in a subsequent PR where I will add a test for MultiUSMesh.

Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #64 (9618729) into master (5656b04) will decrease coverage by 1.01%. The diff coverage is n/a.

:exclamation: Current head 9618729 differs from pull request most recent head 93dc612. Consider uploading reports for the commit 93dc612 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   45.80%   44.78%   -1.02%     
==========================================
  Files           6        6              
  Lines         751      748       -3     
==========================================
- Hits          344      335       -9     
- Misses        407      413       +6     
Impacted Files Coverage Δ
idwarp/UnstructuredMesh.py 60.99% <ø> (-0.04%) :arrow_down:
idwarp/UnstructuredMesh_C.py 46.15% <0.00%> (-53.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5656b04...93dc612. Read the comment docs.

marcomangano commented 2 years ago

As discussed during the maintenance meeting, a test will be added in an upcoming PR

ewu63 commented 2 years ago

@eirikurj @SichengHe could you take a look at this some time? It would be really helpful to get this feature merged.

joanibal commented 2 years ago

@SichengHe @eirikurj. Just another reminder, as I would also like to get this feature on the main branch ASAP