Closed sseraj closed 2 years ago
Merging #66 (3367f42) into master (71640df) will increase coverage by
27.71%
. The diff coverage is93.33%
.
@@ Coverage Diff @@
## master #66 +/- ##
===========================================
+ Coverage 45.72% 73.43% +27.71%
===========================================
Files 6 6
Lines 748 753 +5
===========================================
+ Hits 342 553 +211
+ Misses 406 200 -206
Impacted Files | Coverage Δ | |
---|---|---|
idwarp/MultiUnstructuredMesh_C.py | 91.66% <ø> (+41.66%) |
:arrow_up: |
idwarp/UnstructuredMesh.py | 62.73% <ø> (+1.65%) |
:arrow_up: |
idwarp/MultiUnstructuredMesh.py | 84.61% <92.85%> (+76.38%) |
:arrow_up: |
idwarp/__init__.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 71640df...3367f42. Read the comment docs.
@awccopp @lamkina feel free to go ahead and merge
Purpose
MultiUSMesh was not used or tested, so it broke in several ways over the years. The main fixes here are related to imports, file I/O, and cgns_utils.
I also bumped the version number, and I will make a new release once this is merged.
Type of change
Testing
I added a test using the Onera M6 mesh from the MACH-Aero overset tutorial. The test follows the same structure as the USMesh tests: 1) Regression testing the initial and warped coordinates 2) Complex-step verification of the AD
One of the mesh warping instances uses non-default
aExp
andbExp
, which adds test coverage for the feature added in #64. I took this opportunity to test a bunch of other non-default options as well.Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted