mdolab / openconcept

OpenConcept: A toolkit for conceptual MDAO of aircraft with unconventional propulsion architectures
MIT License
36 stars 32 forks source link

Extend OpenAeroStruct integration to arbitrary planforms #47

Closed eytanadler closed 1 year ago

eytanadler commented 1 year ago

Purpose

This PR extends the OpenAeroStruct drag polar component to work with arbitrary planforms, defined similarly to AVL with linearly-interpolated wing sections. The mesh generation is differentiated to enable using the section parameters as design variables. It remains backward compatible.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

eytanadler commented 1 year ago

Just realized this docs page should be updated with the new changes. Still need to do that.

codecov[bot] commented 1 year ago

Codecov Report

Merging #47 (35fda2d) into main (573f1eb) will decrease coverage by 0.27%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   80.25%   79.99%   -0.27%     
==========================================
  Files          84       85       +1     
  Lines        8974     9297     +323     
==========================================
+ Hits         7202     7437     +235     
- Misses       1772     1860      +88     

see 10 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eytanadler commented 1 year ago

All good to go now

eytanadler commented 1 year ago

Actually actually ready to go now