mdolab / openconcept

OpenConcept: A toolkit for conceptual MDAO of aircraft with unconventional propulsion architectures
MIT License
36 stars 32 forks source link

Fix OpenMDAO install in GitHub Actions build #53

Closed eytanadler closed 1 year ago

eytanadler commented 1 year ago

Purpose

The OpenConcept biweekly build fails because OpenMDAO is no longer installing correctly. The error, which this PR fixes, is:

Collecting openmdao==3.10
  Downloading openmdao-3.10.0.tar.gz (5.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.1/5.1 MB [17](https://github.com/mdolab/openconcept/actions/runs/5225381507/jobs/9619604847#step:5:18).4 MB/s eta 0:00:00
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      error in openmdao setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

codecov[bot] commented 1 year ago

Codecov Report

Merging #53 (c61bfc0) into main (c92037e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files          85       85           
  Lines        9297     9297           
=======================================
  Hits         7437     7437           
  Misses       1860     1860           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eytanadler commented 1 year ago

Ready now. The tests that aren't running are expected. They're old requirements on the branch protection because the names have changed now that I pinned the setuptools version.