mdolab / openconcept

OpenConcept: A toolkit for conceptual MDAO of aircraft with unconventional propulsion architectures
MIT License
36 stars 32 forks source link

Fix duct #59

Closed eytanadler closed 8 months ago

eytanadler commented 9 months ago

Purpose

The compressible duct with the heat exchanger included (ImplicitCompressibleDuct rather than ImplicitCompressibleDuct_ExternalHX) did not have working connections. I think they were probably not updated after other components had been changed or added to the one with the external HX. I've changed them so they match the external heat exchanger one.

I also realized that the pyCycle tests are not run GitHub Actions because pyCycle is not installed. I added the latest version to the install and fixed an outdated pyCycle option in the tests.

Type of change

What types of change is it? Select the appropriate type(s) that describe this PR

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4fc037d) 79.99% compared to head (16ad416) 79.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== - Coverage 79.99% 79.95% -0.04% ========================================== Files 85 85 Lines 9297 9301 +4 ========================================== Hits 7437 7437 - Misses 1860 1864 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.