Closed eytanadler closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4fc037d
) 79.99% compared to head (16ad416
) 79.95%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose
The compressible duct with the heat exchanger included (
ImplicitCompressibleDuct
rather thanImplicitCompressibleDuct_ExternalHX
) did not have working connections. I think they were probably not updated after other components had been changed or added to the one with the external HX. I've changed them so they match the external heat exchanger one.I also realized that the pyCycle tests are not run GitHub Actions because pyCycle is not installed. I added the latest version to the install and fixed an outdated pyCycle option in the tests.
Type of change
What types of change is it? Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.